Adar Dembo has posted comments on this change. Change subject: Fix security tests on macOS ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6176/2/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 388: // macOS's Heimdal library has a no-op implementation of Can you move this higher up so it's part of the existing anonymous namespace? Line 400: if (username.length > len) { Is there an off-by-one error here? It looks like we're OK with username.length == len, but we're going to copy username.length + 1 bytes below, which would be len + 1. -- To view, visit http://gerrit.cloudera.org:8080/6176 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ff10fa47cb7b8ec6f927619e1420fa5e81a7f20 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
