Todd Lipcon has posted comments on this change. Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6160/1/src/kudu/tablet/delta_key.h File src/kudu/tablet/delta_key.h: PS1, Line 75: ATTRIBUTE_HOT > can you leave a comment akin to the one on the commit message here? Done PS1, Line 105: ATTRIBUTE_NOINLINE ATTRIBUTE_COLD > are these redundant? no, because clang doesn't support ATTRIBUTE_COLD. I think COLD also makes gcc place this in a different code section, etc. That said, I ended up moving this to the .cc so I dont think it's as important to use the attributes anymore. -- To view, visit http://gerrit.cloudera.org:8080/6160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0611a3dd1309ab815880c2d151c1270a05f8e406 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
