Todd Lipcon has submitted this change and it was merged.

Change subject: Micro-optimizations to try to inline DeltaKey::DecodeFrom
......................................................................


Micro-optimizations to try to inline DeltaKey::DecodeFrom

This is a hot function in update-heavy workloads (eg YCSB workload A).
This is an attempt to make it inlinable, by marking it "hot" and
out-of-lining the error cases into a function marked "noinline".

Change-Id: I0611a3dd1309ab815880c2d151c1270a05f8e406
Reviewed-on: http://gerrit.cloudera.org:8080/6160
Reviewed-by: David Ribeiro Alves <[email protected]>
Tested-by: Todd Lipcon <[email protected]>
---
M src/kudu/tablet/delta_key.cc
M src/kudu/tablet/delta_key.h
2 files changed, 16 insertions(+), 5 deletions(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Todd Lipcon: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6160
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0611a3dd1309ab815880c2d151c1270a05f8e406
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>

Reply via email to