Todd Lipcon has submitted this change and it was merged. Change subject: cmake: don't incorporate filenames in regexp patterns ......................................................................
cmake: don't incorporate filenames in regexp patterns It leads to incorrect match failures when the filenames contain regexp metacharacters, the worst offender being '+'. I couldn't find a cmake equivalent to java.util.regex.Pattern's \Q and \E control characters, so I rewrote the matching logic with FIND and REPLACE instead. With this change, building from within a directory like kudu-1.2.0+cdh6.x+0/build/fastdebug correctly creates the 'latest' link. Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b Reviewed-on: http://gerrit.cloudera.org:8080/6161 Tested-by: Adar Dembo <[email protected]> Reviewed-by: Todd Lipcon <[email protected]> --- M CMakeLists.txt 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Adar Dembo: Verified Todd Lipcon: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iffbb9cb377625b537212e8244976ffc1b898840b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
