Dan Burkert has posted comments on this change. Change subject: server_negotiation: improve error handling ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6154/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS1, Line 562: > It's not a bug once it's const ref: this is perfectly fine since the langua That's interesting, I didn't know that about C++. unless you strongly object I'm going to keep it as it is right now. We typically haven't pervasively added 'const' qualifiers to local variables in the past. -- To view, visit http://gerrit.cloudera.org:8080/6154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64f9c0f59aa608bf5078d65883a7d9a6fb186c04 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
