Dan Burkert has posted comments on this change. Change subject: server_negotiation: improve error handling ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6154/2/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS2, Line 567: case security::VerificationResult::UNKNOWN_SIGNING_KEY: > Good point. I'm going to change this to ServiceUnavailable to indicate tha Hmm, so I wrote that before looking at the available RPC error codes, and it turns out there is no service unavailable equivalent.https://github.com/apache/kudu/blob/master/src/kudu/rpc/rpc_header.proto#L268. So now I'm not sure what to do. -- To view, visit http://gerrit.cloudera.org:8080/6154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64f9c0f59aa608bf5078d65883a7d9a6fb186c04 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
