Alexey Serbin has posted comments on this change. Change subject: server_negotiation: improve error handling ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6154/1/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS1, Line 562: > That's interesting, I didn't know that about C++. unless you strongly obje Sure, if you are more comfortable with it, please keep it as is. It was a nit, anyway. http://gerrit.cloudera.org:8080/#/c/6154/2/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: PS2, Line 567: case security::VerificationResult::UNKNOWN_SIGNING_KEY: > Hmm, so I wrote that before looking at the available RPC error codes, and i There is ERROR_SERVER_TOO_BUSY which in client internally turns into retries in most scenarios, as I can see. However, it could be nice to have some sort of specific error for that, because in this case it might be not true that the server is too busy. If you feel that FATAL_INVALID_AUTHENTICATION_TOKEN in this case could lead to some undesired conditions, may be it's worth introducing a new RPC error code? -- To view, visit http://gerrit.cloudera.org:8080/6154 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64f9c0f59aa608bf5078d65883a7d9a6fb186c04 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
