Adar Dembo has posted comments on this change. Change subject: [util] conventional signature for Status::operator=() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6175/2/src/kudu/util/status.h File src/kudu/util/status.h: PS2, Line 148: throw(); > sorry, about the ABI change, I was wondering whether it's ABI-breaking to c https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B: "You can...change an inline function or make an inline function non-inline if it is safe that programs linked with the prior version of the library call the old implementation. This is tricky and might be dangerous. Think twice before doing it." So it should be ABI compatible. Is it API compatible though? What exactly does it mean for operator=() to return void anyway? Does that prevent a usage like this? Status s1; Status s2; s2 = s1; -- To view, visit http://gerrit.cloudera.org:8080/6175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04674c88d97204d52bcc15a40755d556f309ea1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
