Todd Lipcon has posted comments on this change. Change subject: [util] conventional signature for Status::operator=() ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/6175/2/src/kudu/util/status.h File src/kudu/util/status.h: PS2, Line 148: throw(); we don't use exception markers anywhere like this, I don't think we should start now. Also, is this an ABI-breaking change? Or no because it's in the headers? Adar? Line 162: Status& operator=(Status&& s) noexcept; same, we don't use noexcept -- To view, visit http://gerrit.cloudera.org:8080/6175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04674c88d97204d52bcc15a40755d556f309ea1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
