Alexey Serbin has posted comments on this change. Change subject: [util] conventional signature for Status::operator=() ......................................................................
Patch Set 3: > > The symbol name's the same, but does a program built against the > > old SO still run properly against the new one? > > Yes -- that I verified as well, sure. Sorry for not mentioning > this. > I used the following to compile it on MacOS X 10.11.6: > > clang++ -shared -o libstatus.so status.cc > clang++ main.cc -o main -L . -lstatus > > The code in the main.cc: > > #include "status.h" > > #include <iostream> > #include <string> > > using namespace std; > > int main() { > Status s0(0); > Status s1(1); > > s0 = s1; > cout << s0.n() << endl; > > Status s2 = 2; > s0 = s2; > > cout << s0.n() << endl; > > return 0; > } And it works if compiled/run at ve0518.halxg.cloudera.com as well. -- To view, visit http://gerrit.cloudera.org:8080/6175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04674c88d97204d52bcc15a40755d556f309ea1 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No