Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures ......................................................................
Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/6170/13/src/kudu/integration-tests/catalog_manager_tsk-itest.cc File src/kudu/integration-tests/catalog_manager_tsk-itest.cc: PS13, Line 61: std::copy(master_flags.begin(), master_flags.end(), : std::back_inserter(cluster_opts_.extra_master_flags)) > you're adding these flags twice, once to common and one to the masters. the I'm not sure I follow -- I'm adding the master flags (which are specific to masters only) to masters, and not adding to common flags. Why do you think those are added twice? PS13, Line 80: // Wait while the cluster runs -- there should be multiple TSK generated. : const double run_time_seconds = AllowSlowTests() ? 300 : 60; : SleepFor(MonoDelta::FromSeconds(run_time_seconds)); > I think we need to have a workload of some sort so that we're sure that eve We can safely use a client to do the work, if necessary. What do kind of workload do we need? Just creation of tables or we want to populate it with some data as well? http://gerrit.cloudera.org:8080/#/c/6170/13/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: Line 605 > oops was commenting on the wrong rev. I see you fixed it, never mind (thoug Done Line 605 > random formatting changes such as this to parts of the code otherwise uncha Done -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
