Dan Burkert has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures ......................................................................
Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/6170/18/src/kudu/integration-tests/catalog_manager_tsk-itest.cc File src/kudu/integration-tests/catalog_manager_tsk-itest.cc: Line 128 mark with TODO(PKI) Line 159 What's forcing leadership change in this test? Line 176 Could you change this so that SmokeTestCluster is run in the thread in a loop, and the main thread sets the atomic? That's how most of these tests are structured. http://gerrit.cloudera.org:8080/#/c/6170/18/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 473: } With the additions below, this path is no longer aborting the task. Should it be? I think it may be appropriate to add a 'continue' after logging the error. PS18, Line 499: eout expiration. this wording isn't clear. It may not be needed at all. -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
