David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures ......................................................................
Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/6170/18/src/kudu/integration-tests/catalog_manager_tsk-itest.cc File src/kudu/integration-tests/catalog_manager_tsk-itest.cc: PS18, Line 71: --raft_enable_pre_election=false ah forgot to suggest that you add this flag. nice. btw if this is a single tablet server setup you just need to set these flags for the master right? PS18, Line 120: ErrorStatusPB::ERROR_UNAVAILABLE does this error transpire all the way to the caller? i.e. could you inspect the status for a particular error and/or string and just ignore it and keep trying until it succeeds? What are the calls in this method that might fail due to an expired/old token? PS18, Line 121: gets authn token signed by the : // key which hasn't yet reached the server. do you mean: "gets authn token signed by the master which hasn't yet reached the tablet server." ? Line 159: // Check that master servers do not crash on change of leadership while > What's forcing leadership change in this test? yeah are you sure that the master leadership is changing? -- To view, visit http://gerrit.cloudera.org:8080/6170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I826826049e3c08a6c8345949690cbbedaea32ff8 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
