David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1931: fix SIGSEGV in file cache RandomAccessFile::memory_footprint() ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6359/1//COMMIT_MSG Commit Message: PS1, Line 22: For now, I've : added some coverage but we really should be running at least one end-to-end : test on all block managers. can you create a jira to make some bm tests parameterized so that we run them with both block managers? http://gerrit.cloudera.org:8080/#/c/6359/1/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: PS1, Line 438: LOG(INFO) is this useful without further context? consider moving to VLOG http://gerrit.cloudera.org:8080/#/c/6359/1/src/kudu/util/file_cache-test.cc File src/kudu/util/file_cache-test.cc: PS1, Line 291: class RandomAccessFileCacheTest : public FileCacheTest<RandomAccessFile> { : }; why not make this a typed test like the others? still covers what you want to cover, right? http://gerrit.cloudera.org:8080/#/c/6359/1/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: PS1, Line 350: // Some anecdotal memory measurements taken inside gdb: : // - glibc 2.23 malloc_usable_size() on make_shared<FileType>: 88 bytes. : // - tcmalloc malloc_usable_size() on make_shared<FileType>: 96 bytes. : // - sizeof(std::shared_ptr::_Sp_counted_base): 16 bytes. : // - sizeof(*this): 72 bytes. would making the descriptor inherit from enable_shared_from this help? alternatively could you add the size of the shared_ptr control block? -- To view, visit http://gerrit.cloudera.org:8080/6359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e57c06dd35252d03729c10ff64fe43d79288513 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
