David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1931: fix SIGSEGV in file cache RandomAccessFile::memory_footprint() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6359/1/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: PS1, Line 438: LOG(INFO) > It is useful: this is the only call to ReadableBlock::memory_footprint() in makes sense. http://gerrit.cloudera.org:8080/#/c/6359/1/src/kudu/util/file_cache.cc File src/kudu/util/file_cache.cc: PS1, Line 350: // Some anecdotal memory measurements taken inside gdb: : // - glibc 2.23 malloc_usable_size() on make_shared<FileType>: 88 bytes. : // - tcmalloc malloc_usable_size() on make_shared<FileType>: 96 bytes. : // - sizeof(std::shared_ptr::_Sp_counted_base): 16 bytes. : // - sizeof(*this): 72 bytes. > _Sp_counted_base isn't portable: there's no class with the same name in lib could you just add sizeof(shared_ptr<Descriptor<RandomAccessFile>>) ? Anecdotally I tried it on my mac and is does indeed return 16bytes -- To view, visit http://gerrit.cloudera.org:8080/6359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e57c06dd35252d03729c10ff64fe43d79288513 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
