Todd Lipcon has posted comments on this change.

Change subject: KUDU-1931: fix SIGSEGV in file cache 
RandomAccessFile::memory_footprint()
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6359/1/src/kudu/util/file_cache.cc
File src/kudu/util/file_cache.cc:

Line 354:     // - sizeof(*this): 72 bytes.
why not add in the sizeof _sp_counted_base?


-- 
To view, visit http://gerrit.cloudera.org:8080/6359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e57c06dd35252d03729c10ff64fe43d79288513
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to