David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index ......................................................................
Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/6376/9/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: PS9, Line 335: INT32_MIN I forget where these come from, but should we use std::limits, for consistency? maybe pull a constant if you're gonna use them repeatedly PS9, Line 389: NO_FATALS(); isn't the usual practice to wrap AssertEventually in NO_FATALS? PS9, Line 391: Now, remove PS9, Line 418: NO_FATALS(); same http://gerrit.cloudera.org:8080/#/c/6376/9/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: PS9, Line 800: CHECK_LT(overflow, FLAGS_group_commit_queue_size_bytes) << OpIdToString(*opid); this is a bit finnicky. The gc queue size could in theory be changed between shutdown and restart. Moreover, is there a chance that more than one group commit went through? -- To view, visit http://gerrit.cloudera.org:8080/6376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
