David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index ......................................................................
Patch Set 9: Code-Review+2 (2 comments) +2 feel free to address the nits or not. http://gerrit.cloudera.org:8080/#/c/6376/9/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: PS9, Line 391: Now, > Why? adds no information? i.e. you can have just "Write some.." and it has the same meaning. In any case I don't feel strongly about it, so if you feel its important I'm ok with leaving too. http://gerrit.cloudera.org:8080/#/c/6376/9/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: PS9, Line 800: CHECK_LT(overflow, FLAGS_group_commit_queue_size_bytes) << OpIdToString(*opid); > 1. This is a size in bytes, not entries, and the default is 4M. So I believ just feel it's kind of an arbitrary comparison (i.e. why 1 byte per entry if an entry has a min size?). In any case I don't think it matters too much. -- To view, visit http://gerrit.cloudera.org:8080/6376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
