Mike Percy has posted comments on this change. Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log index ......................................................................
Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6376/9/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: PS9, Line 391: Now, > adds no information? i.e. you can have just "Write some.." and it has the s I don't really feel it's important, it's just kind of a narrative style that I don't think warrants revising the patch over. But if there are other things I need to address I'm not resistant to removing it. http://gerrit.cloudera.org:8080/#/c/6376/9/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: PS9, Line 800: CHECK_LT(overflow, FLAGS_group_commit_queue_size_bytes) << OpIdToString(*opid); > just feel it's kind of an arbitrary comparison (i.e. why 1 byte per entry i I just wanted a sanity check to ensure we don't apply this "repair" logic to other, unrelated bugs. Do you have any suggestions on how to improve this? I thought dedicating a gflag to this was a bit overkill but I could do that instead if you think it's an improvement... -- To view, visit http://gerrit.cloudera.org:8080/6376 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
