Adar Dembo has posted comments on this change. Change subject: KUDU-1769: fs check action with rudimentary data block GC ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6361/1/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: Line 72: Status Check(const RunnerContext& context) { > warning: parameter 'context' is unused [misc-unused-parameters] Done PS1, Line 75: FsManagerOpts() > opts Good catch. As penance, I've added a test that fails with because of this buglet, but passes with the fix. Line 143: Status Format(const RunnerContext& context) { > warning: parameter 'context' is unused [misc-unused-parameters] Done -- To view, visit http://gerrit.cloudera.org:8080/6361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82da8e234c338cd5a7540a22cebfa0a4958388ec Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
