Dinesh Bhat has posted comments on this change. Change subject: KUDU-1769: fs check action with rudimentary data block GC ......................................................................
Patch Set 2: Code-Review+1 (3 comments) Thanks for adding this Adar, LGTM, couple of minor comments below. http://gerrit.cloudera.org:8080/#/c/6361/2//COMMIT_MSG Commit Message: Line 24: I do expect that the block manager will take on some check or repair duties, Thinking aloud, would it make sense to run the scan of orphan blocks every now and then as a mantainance manager background task and once the number of orphan blocks crosses certain threshold, perhaps trigger the repair ? http://gerrit.cloudera.org:8080/#/c/6361/2/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: PS2, Line 50: repair I wonder if term 'repair' could give any wrong impression about the underlying operation being performed. We are cleaning up the orphan blocks and fixing inconsistency for sure, but functionality is not similar to fsck --repair kinda I guess, and I don't have any better alternative word suggestion either :(. may be --free_orphan_blocks ? PS2, Line 72: /*context*/ Is this a way to silence unused warnings ? -- To view, visit http://gerrit.cloudera.org:8080/6361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82da8e234c338cd5a7540a22cebfa0a4958388ec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
