Adar Dembo has posted comments on this change. Change subject: KUDU-1769: fs check action with rudimentary data block GC ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/6361/2//COMMIT_MSG Commit Message: Line 24: I do expect that the block manager will take on some check or repair duties, > Thinking aloud, would it make sense to run the scan of orphan blocks every Blocks can only be orphaned in the event of a crash, so there's no reason to scan for orphaned blocks outside of startup (and/or this tool). http://gerrit.cloudera.org:8080/#/c/6361/2/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: PS2, Line 50: repair > I wonder if term 'repair' could give any wrong impression about the underl I expect --repair to sprout additional functionality over time, which is why I chose a more generic verb. PS2, Line 72: /*context*/ > Is this a way to silence unused warnings ? I don't think we necessarily want to silence them; I'm happy to make whatever changes are needed to comply with clang-tidy. -- To view, visit http://gerrit.cloudera.org:8080/6361 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82da8e234c338cd5a7540a22cebfa0a4958388ec Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
