Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1962. Fix NPE when master returns SERVER_TOO_BUSY ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java: PS1, Line 314: return deferred.join(); > what's the plan with adding a join timeout back in? e.g. adding 10 sec to t Would do that separately, need to think about it more. http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: Line 38: import com.google.common.base.Preconditions; Remove http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java: Line 57: public void testMasterLookupOverflow() throws Exception { How long does this run for usually? Maybe make it an integration test so it only runs on mvn verify? -- To view, visit http://gerrit.cloudera.org:8080/6516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4aba2e39f05488da500c18247c72181c8e9dceb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
