Todd Lipcon has posted comments on this change.

Change subject: KUDU-1962. Fix NPE when master returns SERVER_TOO_BUSY
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java:

PS1, Line 314: return deferred.join();
> what's the plan with adding a join timeout back in? e.g. adding 10 sec to t
I think it would be good, but I don't think the admin timeout is always right, 
because the op timeout might be longer than the admin timeout. We'd probably 
need to apply these for each particular case.

For 1.3.1 at least I think we should not try to change this.


-- 
To view, visit http://gerrit.cloudera.org:8080/6516
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4aba2e39f05488da500c18247c72181c8e9dceb
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to