Todd Lipcon has posted comments on this change. Change subject: KUDU-1962. Fix NPE when master returns SERVER_TOO_BUSY ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: Line 38: import com.google.common.base.Preconditions; > Remove Done http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java: Line 57: public void testMasterLookupOverflow() throws Exception { > How long does this run for usually? Maybe make it an integration test so it Only 13 seconds, so I think it's not too bad. http://gerrit.cloudera.org:8080/#/c/6516/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMasterFailover.java: PS1, Line 88: @Test(timeout = 60000) : public void testUseClientsWhenMastersDown() throws Exception { : List<KuduClient> clients = new ArrayList<KuduClient>(); : clients.add(syncClient); : for (int i = 0; i < 2; i++) { : killMasterLeader(); : clients.add(new KuduClient.KuduClientBuilder(miniCluster.getMasterAddresses()).build()); : for (KuduClient c : clients) { : c.listTabletServers(); : } : } : : } > oops, I didn't mean to leave this test in. I think it will fail. Done -- To view, visit http://gerrit.cloudera.org:8080/6516 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4aba2e39f05488da500c18247c72181c8e9dceb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
