Sailesh Mukil has posted comments on this change. Change subject: Replace deprecated OpenSSL function ERR_remove_state() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6556/2/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: Line 150: ERR_remove_thread_state(nullptr); > I agree it's good to move away from the deprecated call, but is this the ri Hmm, that's true. It's not an incorrect usage, since once the next TlsSocket on that reactor thread tries to use OpenSSL, a new error queue will be allocated. "Since error queue data structures are allocated automatically for new threads, they must be freed when threads are terminated in order to avoid memory leaks." - OpenSSL docs However, we could do away with the time spent allocating and freeing this queue unnecessarily (I'm not sure how expensive it is though). Which means that ReactorThread::Shutdown() would be the ideal place to call ERR_remove_thread_state() ? And we could replace this call with ERR_clear_error(). -- To view, visit http://gerrit.cloudera.org:8080/6556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0d2895cd331f94ad383e8666b84e15bfc035d3a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
