Todd Lipcon has posted comments on this change. Change subject: Replace deprecated OpenSSL function ERR_remove_state() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6556/2/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: Line 150: ERR_remove_thread_state(nullptr); I agree it's good to move away from the deprecated call, but is this the right place for it in the first place? Our usual use case for TlsSocket is on reactor threads which have lots of active sockets to different hosts, so just because one socket closed doesn't mean the thread is done using OpenSSL libraries, right? -- To view, visit http://gerrit.cloudera.org:8080/6556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0d2895cd331f94ad383e8666b84e15bfc035d3a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
