Todd Lipcon has posted comments on this change. Change subject: Replace deprecated OpenSSL function ERR_remove_state() ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6556/2/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: Line 150: ERR_remove_thread_state(nullptr); > Hmm, that's true. It's not an incorrect usage, since once the next TlsSocke Yea, I think moving it to ReactorThread::ShutdownInternal is a good spot (Shutdown() is the call which asks the thread to shut down, and ShutdownInternal runs on the thread). https://gerrit.cloudera.org/#/c/6552/ is another open gerrit which is handling adding ERR_clear_error() in appropriate spots, so worth rebasing on top of that one if you are making a change here. I don't think we need ERR_clear_error() here because we are already using GetSSLErrorDescription() above, which I think has the side effect of clearing errors. (and per the above gerrit we discovered that ERR_clear_error has bad perf side effects) -- To view, visit http://gerrit.cloudera.org:8080/6556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0d2895cd331f94ad383e8666b84e15bfc035d3a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
