Adar Dembo has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 118: We should probably document something about the data format. And say something about the compatibility contract of that format. Are we allowed to change the format? Or are we locked into it once exposed in this way? Line 124: private: Nit: separate from indirect_data() with an empty line. -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
