Todd Lipcon has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 118: > Todd: do you mean that we should start versioning wire_protocol and that we Sort of the other way around... Given the client implementation currently only speaks one version of "wire protocol", we know that given a particular client shared object, it will be exactly that format in memory. So, it's enough for the user of the API (i.e. Impala) to basically CHECK() that the shared library it's running against matches the same one it was built against. We don't need to actually check anything about the server side, since the client-side and server-side here are tightly coupled. So one solution would be for impala to CHECK something about the returned string from GetKuduVersion() or whatever. But that seems a little fragile in that it would have to get updated every time we bumped version number, etc. So I'm suggesting we pass it as a parameter here, and have the other side CHECK if it doesn't match. Another solution would be to say that, if we change the in-memory format, we'll rename/remove these methods, so that a program linked against the old client (expecting the old format) would get a link error if it attempted to run against a new client. -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
