Todd Lipcon has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/1/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: Line 118: > We should probably document something about the data format. And say someth I think rather than documenting, we should explicitly document that it's advanced/undocumented/unstable/etc with all the warning labels. Anyone who wants to consume this should tightly couple themselves to a particular version of the client and be advanced enough to read the source code, IMO. As a safeguard, though, perhaps we should add a parameter like a version number and CHECK from the .cc file that the parameter matches? That way if we accidentally ran against the wrong client.so, we'd get a CHECK crash instead of a surprising result? -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
