Alexey Serbin has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6574/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS6, Line 379: direct_data Does it make sense (if it possible at all) to add some test or function which would exercise the KuduScanBatch::indirect_data method as well? PS6, Line 387: if (num_projected_cols != 4) return; Why is this shortcut? What if there were just 3 projected columns? -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
