Matthew Jacobs has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/6574/9/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: PS9, Line 130: Slice direct_data() const; : : /// Like the method above, but for indirect data. : /// : /// @return a Slice that points to the raw indirect row data. : Slice indirect_data() const; : ///@} can you comment on the lifetime of the data? i.e. the caller can use the slice until the batch is deconstructed? the user should copy any data that will live longer than the batch? -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
