David Ribeiro Alves has posted comments on this change. Change subject: Allow to get the raw data from a KuduScanBatch ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/6574/6/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS6, Line 379: direct_data > Does it make sense (if it possible at all) to add some test or function whi it's hard to understand the indirect data by itself. The direct data has pointers places in it so we end up indirectly getting stuff form it (like in LOC 395/396), the indirect_data method is mostly so that the caller gets the location and size of it so that it can account for its memory or allocate a buffer of the same size. PS6, Line 387: if (num_projected_cols != 4) return; > Why is this shortcut? What if there were just 3 projected columns? the methods that call this only have one or all 4 columns projected. I changed this to return on the 1 case (clearer). http://gerrit.cloudera.org:8080/#/c/6574/5/src/kudu/client/scan_batch.h File src/kudu/client/scan_batch.h: PS5, Line 120: // > this should be Done PS5, Line 123: // > this should be Done -- To view, visit http://gerrit.cloudera.org:8080/6574 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c9ad5aa7c5f45a87827352597a404241912342f Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
