Adar Dembo has posted comments on this change. Change subject: WIP: simplify MemTracker and move process throttling elsewhere ......................................................................
Patch Set 1: Not sure exactly what your plan is, so I'll just list the things that I found surprising: 1. Why preserve the hierarchical nature of MemTracker? Based on our in-person discussion yesterday, I thought all of the things worth tracking are isolated from another. 2. Why preserve the root tracker? 3. Do MemTrackers still need shared ownership? If so, why? If you agree that the above three things can be removed, I think you'll end up removing more than is actually left behind; that is, it may be simpler to reimplement based on the new set of requirements than it is to pare the existing MemTracker down. -- To view, visit http://gerrit.cloudera.org:8080/6620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id16bad7d9a29a83e820a38e9d703811391cffe90 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: No
