Hello David Ribeiro Alves, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6620
to review the following change.
Change subject: WIP: simplify MemTracker and move process throttling elsewhere
......................................................................
WIP: simplify MemTracker and move process throttling elsewhere
This takes a first step towards simplifying MemTracker:
- Remove the "GC function" callbacks (we never used this)
- Remove the 'ExpandLimits' code which was unimplemented.
- Remove the logging functionality, which we've never used
as far as I can remember.
- Remove soft limiting. We only used this on the root tracker, so
I just moved it to a new process_memory.{h,cc}
- Remove 'consumption_func' and un-tie the root tracker from
the global process memory usage. Now the root tracker is a simple
sum of its descendents.
Change-Id: Id16bad7d9a29a83e820a38e9d703811391cffe90
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/util/CMakeLists.txt
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/maintenance_manager.cc
M src/kudu/util/maintenance_manager.h
M src/kudu/util/mem_tracker-test.cc
M src/kudu/util/mem_tracker.cc
M src/kudu/util/mem_tracker.h
A src/kudu/util/process_memory.cc
A src/kudu/util/process_memory.h
12 files changed, 287 insertions(+), 434 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/6620/1
--
To view, visit http://gerrit.cloudera.org:8080/6620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id16bad7d9a29a83e820a38e9d703811391cffe90
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
