Todd Lipcon has posted comments on this change. Change subject: WIP: simplify MemTracker and move process throttling elsewhere ......................................................................
Patch Set 2: Adar -- do you have any reservations about this particular patch? Or just suggesting it might be easier to start clean? If you aren't strongly against, I'd like to continue down this route. Once this patch is committed, we'll have better separation between MemTracker and throttling logic, and can make some progress on improving the throttling vs flush-triggering issues discussed in https://docs.google.com/document/d/17-2CcmrjxZY0Gd9wDUh83xCCNL574famw8_2Bhfu-_8/edit The missing piece that makes this a WIP is periodically triggering the tcmalloc ReleaseMemory() call as necessary, after which point I think it should be committable. -- To view, visit http://gerrit.cloudera.org:8080/6620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id16bad7d9a29a83e820a38e9d703811391cffe90 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: No
