Hello David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6741
to review the following change.
Change subject: subprocess: add ScopedSubprocess
......................................................................
subprocess: add ScopedSubprocess
This patch introduces an RAII wrapper around a Subprocess, best suited for
processes that should run alongside a unit test and should be killed
indiscriminately when the test ends.
I intend to use this in the dense node test for "perf", and I changed the
existing perf calls in full_stack-insert-scan-test to use it. While there I
fixed the handling of "--call-graph"; passing it without "fp" is a syntax
error on both el6.6 and Ubuntu 16.04.
Change-Id: Iaf31bd4ea6de2917521a9852714fb33cfbec1f61
---
M src/kudu/integration-tests/full_stack-insert-scan-test.cc
M src/kudu/util/subprocess-test.cc
M src/kudu/util/subprocess.h
3 files changed, 99 insertions(+), 30 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/6741/1
--
To view, visit http://gerrit.cloudera.org:8080/6741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf31bd4ea6de2917521a9852714fb33cfbec1f61
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: David Ribeiro Alves <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
