Adar Dembo has submitted this change and it was merged. Change subject: subprocess: add KillAndWait() and allow customization of exit signal ......................................................................
subprocess: add KillAndWait() and allow customization of exit signal This patch does two things: - It introduces a KillAndWait() method that terminates and fully reaps a process. - It allows one to customize the exit signal delivered to a subprocess when it goes out of scope. The default signal is SIGKILL which doesn't let subprocesses clean up after themselves. Change-Id: Iaf31bd4ea6de2917521a9852714fb33cfbec1f61 Reviewed-on: http://gerrit.cloudera.org:8080/6741 Tested-by: Adar Dembo <[email protected]> Reviewed-by: David Ribeiro Alves <[email protected]> --- M src/kudu/util/subprocess-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/subprocess.h 3 files changed, 113 insertions(+), 8 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/6741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf31bd4ea6de2917521a9852714fb33cfbec1f61 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]>
