Todd Lipcon has posted comments on this change. Change subject: subprocess: add KillAndWait() and allow customization of exit signal ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6741/1/src/kudu/integration-tests/full_stack-insert-scan-test.cc File src/kudu/integration-tests/full_stack-insert-scan-test.cc: PS1, Line 232: string cmd = Substitute("perf record --pid=$0", getpid()); : if (FLAGS_perf_fp_flag) cmd += " --call-graph fp"; > What systems are those? On the two that I tested (Ubuntu 16 and el6.6) "per Going back to the original code review which introduced this, Vlad said "The only issue is that adding "fp" will break on el6 since that parameter doesn't take an argument in older perf versions." I'm guessing this refers to <el6.3 or somesuch which we don't support anymore due to other issues, so should be fine now to do what you did. But, we should probably rename --perf_fp_flag to --perf_collect_callgraph or something -- To view, visit http://gerrit.cloudera.org:8080/6741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf31bd4ea6de2917521a9852714fb33cfbec1f61 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
