David Ribeiro Alves has posted comments on this change. Change subject: Add fault injection of EIOs ......................................................................
Patch Set 2: (5 comments) a small directed test would be nice. maybe just add a test to env_util test where you set the prob flag to 1 and make sure the methods you care about return what you want. http://gerrit.cloudera.org:8080/#/c/6881/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS2, Line 129: the operation should attempt to fail without crashing maybe "If false, EIOs are just cause an Status::IOError to be returned. In this case, it's up to the caller to decide how to handle the error." Line 149: extra line PS2, Line 150: env_inject_eio any operation or just the ones that whose filenames match the regex below? PS2, Line 283: WARNING use ERROR instead? Line 1651: spurious change -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
