Andrew Wong has posted comments on this change. Change subject: Add fault injection of EIOs ......................................................................
Patch Set 4: (25 comments) http://gerrit.cloudera.org:8080/#/c/6881/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: PS2, Line 129: error-handling up to the caller."); > maybe "If false, EIOs are just cause an Status::IOError to be returned. In Done. Line 149: > extra line Done PS2, Line 150: env_inject_eio > any operation or just the ones that whose filenames match the regex below? Is it okay for flag descriptions to refer to "above" or "below," wrt code placement? For now, I'll keep it vague and say "operations on certain files" instead of "any." PS2, Line 283: ERROR) > use ERROR instead? Done Line 290: MAYBE_INJECT_EIO(filename, IOError(Env::kInjectedFailureStatusMsg, EIO)); > warning: local copy 'f_' of the variable 'filename' is never modified; cons Done Line 311: MAYBE_INJECT_EIO(filename, IOError(Env::kInjectedFailureStatusMsg, EIO)); > warning: local copy 'f_' of the variable 'filename' is never modified; cons Done Line 335: MAYBE_INJECT_EIO(filename, IOError(Env::kInjectedFailureStatusMsg, EIO)); > warning: local copy 'f_' of the variable 'filename' is never modified; cons Done Line 404: MAYBE_INJECT_EIO(filename, IOError(Env::kInjectedFailureStatusMsg, EIO)); > warning: local copy 'f_' of the variable 'filename' is never modified; cons Done Line 953: ThreadRestrictions::AssertIOAllowed(); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 973: ThreadRestrictions::AssertIOAllowed(); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1044: ThreadRestrictions::AssertIOAllowed(); > warning: local copy 'f_' of the variable 'dir' is never modified; consider Done Line 1062: ThreadRestrictions::AssertIOAllowed(); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1072: TRACE_EVENT1("io", "PosixEnv::CreateDir", "path", name); > warning: local copy 'f_' of the variable 'name' is never modified; consider Done Line 1083: TRACE_EVENT1("io", "PosixEnv::DeleteDir", "path", name); > warning: local copy 'f_' of the variable 'name' is never modified; consider Done Line 1107: TRACE_EVENT1("io", "PosixEnv::ChangeDir", "dest", dest); > warning: local copy 'f_' of the variable 'dest' is never modified; consider Done Line 1118: TRACE_EVENT1("io", "SyncDir", "path", dirname); > warning: local copy 'f_' of the variable 'dirname' is never modified; consi Done Line 1139: TRACE_EVENT1("io", "PosixEnv::GetFileSize", "path", fname); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1153: TRACE_EVENT1("io", "PosixEnv::GetFileSizeOnDisk", "path", fname); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1183: TRACE_EVENT1("io", "PosixEnv::GetBlockSize", "path", fname); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1197: TRACE_EVENT1("io", "PosixEnv::GetFileModifiedTime", "fname", fname); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1215: ThreadRestrictions::AssertIOAllowed(); > warning: local copy 'f_' of the variable 'path' is never modified; consider Done Line 1235: MAYBE_INJECT_EIO(target, IOError(Env::kInjectedFailureStatusMsg, EIO)); > warning: local copy 'f_' of the variable 'src' is never modified; consider Done Line 1236: TRACE_EVENT2("io", "PosixEnv::RenameFile", "src", src, "dst", target); > warning: local copy 'f_' of the variable 'target' is never modified; consid Done Line 1247: TRACE_EVENT1("io", "PosixEnv::LockFile", "path", fname); > warning: local copy 'f_' of the variable 'fname' is never modified; conside Done Line 1651: > spurious change Done -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
