Adar Dembo has posted comments on this change. Change subject: Add fault injection of EIOs ......................................................................
Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/6881/12//COMMIT_MSG Commit Message: Line 10: a flag-specified glob pattern indicating which paths should fail What made you decide to use globbing instead of regexes? I don't have an opinion one way or the other, but am curious to know the motivation for the change. http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 150: TAG_FLAG(env_inject_eio, hidden); > We can, although there's the subtlety that suicide_on_eio should be switche As of PS12 I see still see both env_inject_io_error and env_inject_eio. Are you still working on combining them? http://gerrit.cloudera.org:8080/#/c/6881/8/src/kudu/util/fault_injection.h File src/kudu/util/fault_injection.h: Line 46: // Note that 'status_expr' is evaluated even if 'fraction_flag' is zero. > Yeah that's MAYBE_EVAL_AND_RETURN_FAILURE. Will replace the implementation Are you still working on this? -- To view, visit http://gerrit.cloudera.org:8080/6881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5190d5e7f296cf27b65f1ecd2c16f3315cc46a39 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
