Todd Lipcon has posted comments on this change. Change subject: [rpc] introduce per-RPC credentials policy ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6875/5/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: PS5, Line 163: SatisfiesCredentialsPolicy this seems a little hard to follow. This makes it sound like "Are primary credentials allowed? If so, don't use the token." which doesn't sound quite logical. How about just doing conn->credentials_policy() == PRIMARY_CREDENTIALS, and maybe rename PRIMARY_CREDENTIALS to PRIMARY_CREDENTAILS_ONLY or NO_TOKENS or something more specific? -- To view, visit http://gerrit.cloudera.org:8080/6875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52f806e7b6f6362f66148530124e748e199ae6c2 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
