Todd Lipcon has posted comments on this change. Change subject: [rpc] introduce per-RPC credentials policy ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6875/5/src/kudu/rpc/negotiation.cc File src/kudu/rpc/negotiation.cc: PS5, Line 163: SatisfiesCredentialsPolicy > FWIW I like the PRIMARY name. This logic may end up changing if we go the yea, I think my main complaint about this is that we're calling SatisfiesCredentialsPolicy on a connection that has not yet negotiated, which seems a bit odd. To me the name of the method implies that we're checking whether the negotiated authentication of a connection satistifes some policy, but here we are deciding _how_ to negotiate based on its configured policy. -- To view, visit http://gerrit.cloudera.org:8080/6875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52f806e7b6f6362f66148530124e748e199ae6c2 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
