Alexey Serbin has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired ......................................................................
Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/6648/16/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: PS16, Line 731: ANY_BUT_AUTHN_OTKEN > this isn't the current name (though I actually like something like you have You are right -- that's the old name (with an additional typo). Now it's PRIMARY_CREDENTIALS. I'll update this. The new naming looks more generic. http://gerrit.cloudera.org:8080/#/c/6648/16/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: PS16, Line 237: scoped_refptr<internal::ConnectToClusterRpc> leader_master_rpc_any_creds_; : std::vector<StatusCallback> leader_master_callbacks_any_creds_; : scoped_refptr<internal::ConnectToClusterRpc> leader_master_rpc_primary_creds_; : std::vector<StatusCallback> leader_master_callbacks_primary_creds_; > is it really necessary to split the callbacks? eg if you try to request a C Yes, the idea was to not wait for that re-connection again in that rare case. -- To view, visit http://gerrit.cloudera.org:8080/6648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418497ac59cfd4e476e9bfc6abe6b10b487712f5 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
