Alexey Serbin has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired ......................................................................
Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/6648/16/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 753: if (leader_master_rpc_primary_creds_ || need_new_rpc_primary_creds) { > I think the version you came up with which is something of a hybrid is the I'm glad my micro-updates did not bring confusion this time :) Thank you for pointing to this piece and providing a clearer alternative. Line 761: scoped_refptr<internal::ConnectToClusterRpc>& rpc( > Yah I was confused, I thought this was actually calling scoped_refptr const I agree that this part was not good for a reader. At least, two readers in a row got confused :) A clear sign that something needs to be changed. -- To view, visit http://gerrit.cloudera.org:8080/6648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418497ac59cfd4e476e9bfc6abe6b10b487712f5 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
