Alexey Serbin has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired ......................................................................
Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/6648/16/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: Line 753: if (leader_master_rpc_primary_creds_ || need_new_rpc_primary_creds) { > I was having a hard time following this, so I tried to take a crack at redu I asked Mike to look at this as well to have an additional independent reviewer :) To Mike the reference thing was also confusing. Also, both variants looked not so good to him, so I decided to go with the alternative that you proposed: if you trust that code better, let it be the trusted code. I also found it doing the right thing, but I also spent some time to make sure it behaves like I want it to behave. -- To view, visit http://gerrit.cloudera.org:8080/6648 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418497ac59cfd4e476e9bfc6abe6b10b487712f5 Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
