Will Berkeley has submitted this change and it was merged. Change subject: KUDU-2001 Refactor rowset size estimates ......................................................................
KUDU-2001 Refactor rowset size estimates Currently, Rowset::EstimateOnDiskSize() serves two purposes: 1. An estimate of the total size of the rowset, which is exposed when rolled into the tablet's on-disk size metric. 2. An estimate of the benefit of compaction. These two purposes conflicted-- the compaction size counts only base data and redo deltas that are relevant for compaction, so e.g. undo deltas are omitted from the estimate. This patch separates these two purposes. EstimateOnDiskSize() remains the method for purpose #1, while a new method EstimateCompactionSize() is introduced for purpose #2. EstimateOnDiskSize now includes undo deltas, and so is more accurate than before (however, there's more work to do: see KUDU-1755). There should be no changes to compaction policy as a result of this patch. Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Reviewed-on: http://gerrit.cloudera.org:8080/6850 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/tablet/compaction_policy-test.cc M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/delta_tracker.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/tablet.cc 12 files changed, 101 insertions(+), 15 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]>
