Todd Lipcon has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6850/5/src/kudu/tablet/diskrowset.cc File src/kudu/tablet/diskrowset.cc: Line 692: return base_data_->EstimateOnDiskSize() + delta_tracker_->EstimateOnDiskSize(); > You're right about this. That needs to be adjusted as well. There should al I'm not too surprised that no tests failed -- we tend not to get too white-boxy with the tests making super-specific assertions about number of bytes, since those tend to change a lot with other unrelated changes. The worry is more about the "emergent behavior" of a real workload, which is harder to see in a test environment, since we currently don't really have any "ultra-long" type tests with many GB of data involved running precommit. -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
